m1a2st commented on code in PR #16899:
URL: https://github.com/apache/kafka/pull/16899#discussion_r1858506422
##########
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##########
@@ -666,7 +686,8 @@ protected Map<String, Object> postProcessParsedConfig(final
Map<String, Object>
Map<String, Object> refinedConfigs =
CommonClientConfigs.postProcessReconnectBackoffConfigs(this, parsedValues);
maybeOverrideClientId(refinedConfigs);
maybeOverrideEnableAutoCommit(refinedConfigs);
- checkGroupRemoteAssignor();
+ checkUnsupportedConfigs(GroupProtocol.CLASSIC,
CLASSIC_PROTOCOL_UNSUPPORTED_CONFIGS);
+ checkUnsupportedConfigs(GroupProtocol.CONSUMER,
CONSUMER_PROTOCOL_UNSUPPORTED_CONFIGS);
Review Comment:
I prefer the current approach because it allows us to reuse this method in
the future if new protocols are added, without having to add additional if-else
statements to the original method. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
