frankvicky commented on code in PR #17946:
URL: https://github.com/apache/kafka/pull/17946#discussion_r1860239686
##########
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java:
##########
@@ -2154,6 +2154,32 @@ public void testCallbackAndInterceptorHandleError() {
}
}
+ @Test
+ public void shouldNotInvokeFlushInCallback() {
+ Map<String, Object> configs = new HashMap<>();
+ configs.put(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG, "localhost:9000");
+ configs.put(ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG, false);
Review Comment:
This setting aims to simplify our test case. Here's my understanding—please
correct me if I'm wrong:
Since idempotence is enabled by default, if we don't explicitly set it to
false, we would need to prepare additional data to go through the idempotence
flow. I believe this is unnecessary for this test case, so I will add a comment
to clarify. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
