mimaison commented on code in PR #17681:
URL: https://github.com/apache/kafka/pull/17681#discussion_r1860491485
##########
clients/src/main/resources/common/message/FetchResponse.json:
##########
@@ -72,28 +72,33 @@
{ "name": "HighWatermark", "type": "int64", "versions": "0+",
"about": "The current high water mark." },
{ "name": "LastStableOffset", "type": "int64", "versions": "4+",
"default": "-1", "ignorable": true,
- "about": "The last stable offset (or LSO) of the partition. This is
the last offset such that the state of all transactional records prior to this
offset have been decided (ABORTED or COMMITTED)" },
+ "about": "The last stable offset (or LSO) of the partition. This is
the last offset such that the state of all transactional records prior to this
offset have been decided (ABORTED or COMMITTED)." },
{ "name": "LogStartOffset", "type": "int64", "versions": "5+",
"default": "-1", "ignorable": true,
"about": "The current log start offset." },
{ "name": "DivergingEpoch", "type": "EpochEndOffset", "versions":
"12+", "taggedVersions": "12+", "tag": 0,
- "about": "In case divergence is detected based on the
`LastFetchedEpoch` and `FetchOffset` in the request, this field indicates the
largest epoch and its end offset such that subsequent records are known to
diverge",
+ "about": "In case divergence is detected based on the
`LastFetchedEpoch` and `FetchOffset` in the request, this field indicates the
largest epoch and its end offset such that subsequent records are known to
diverge.",
"fields": [
- { "name": "Epoch", "type": "int32", "versions": "12+", "default":
"-1" },
- { "name": "EndOffset", "type": "int64", "versions": "12+",
"default": "-1" }
+ { "name": "Epoch", "type": "int32", "versions": "12+", "default":
"-1",
+ "about": "The largest epoch." },
+ { "name": "EndOffset", "type": "int64", "versions": "12+",
"default": "-1",
+ "about": "The end offset of the epoch." }
]},
{ "name": "CurrentLeader", "type": "LeaderIdAndEpoch",
"versions": "12+", "taggedVersions": "12+", "tag": 1, "fields": [
{ "name": "LeaderId", "type": "int32", "versions": "12+", "default":
"-1", "entityType": "brokerId",
"about": "The ID of the current leader or -1 if the leader is
unknown."},
{ "name": "LeaderEpoch", "type": "int32", "versions": "12+",
"default": "-1",
- "about": "The latest known leader epoch"}
- ]},
+ "about": "The latest known leader epoch." }
+ ],
+ "about": "The current leader of the partition." },
{ "name": "SnapshotId", "type": "SnapshotId",
"versions": "12+", "taggedVersions": "12+", "tag": 2,
"about": "In the case of fetching an offset less than the
LogStartOffset, this is the end offset and epoch that should be used in the
FetchSnapshot request.",
"fields": [
- { "name": "EndOffset", "type": "int64", "versions": "0+",
"default": "-1" },
- { "name": "Epoch", "type": "int32", "versions": "0+", "default":
"-1" }
+ { "name": "EndOffset", "type": "int64", "versions": "0+",
"default": "-1",
+ "about": "The end offset of the epoch." },
+ { "name": "Epoch", "type": "int32", "versions": "0+", "default":
"-1",
+ "about": "The largest epoch." }
Review Comment:
Can we move this above the fields?
Same just below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
