chia7712 commented on code in PR #17440:
URL: https://github.com/apache/kafka/pull/17440#discussion_r1860948200
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java:
##########
@@ -150,6 +152,7 @@ private void maybePropagateMetadataError() {
try {
metadata.maybeThrowAnyException();
} catch (Exception e) {
+ metadataError = Optional.of(e);
backgroundEventHandler.add(new ErrorEvent(e));
Review Comment:
> Then why exactly is it that we still need to propagate them via
ErrorEvents still too?
I agree with this comment; it would be beneficial to have a unified way to
propagate errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
