dajac commented on code in PR #17964:
URL: https://github.com/apache/kafka/pull/17964#discussion_r1862607964
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMetadata.java:
##########
@@ -68,7 +68,7 @@ public boolean allowAutoTopicCreation() {
@Override
public synchronized MetadataRequest.Builder newMetadataRequestBuilder() {
- if (subscription.hasPatternSubscription())
+ if (subscription.hasPatternSubscription() ||
subscription.hasRe2JPatternSubscription())
Review Comment:
This is correct for when the consumer subscribed by topic names or by
server-side regex. They are actually the same. The only exception is the
client-side regex but this will be deprecated soon.
Overall, I would say that we should update the subscription state to operate
with topic ids. This could also allow use to simplify the membership manager.
We have been talking about doing this for a while now but we never this. It may
be the time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
