chia7712 commented on code in PR #17982:
URL: https://github.com/apache/kafka/pull/17982#discussion_r1863285991
##########
server/src/main/java/org/apache/kafka/server/config/AbstractKafkaConfig.java:
##########
@@ -43,31 +43,32 @@
*/
public abstract class AbstractKafkaConfig extends AbstractConfig {
@SuppressWarnings("deprecation")
Review Comment:
Could you please remove this unused `SuppressWarnings` also?
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -367,6 +383,26 @@ public GroupCoordinatorConfig(AbstractConfig config) {
SHARE_GROUP_HEARTBEAT_INTERVAL_MS_CONFIG,
SHARE_GROUP_SESSION_TIMEOUT_MS_CONFIG));
}
+ @SuppressWarnings("unchecked")
+ private static List<ConsumerGroupPartitionAssignor> consumerGroupAssignors(
+ AbstractConfig config
+ ) {
+ // In unit tests, it is pretty convenient to have the ability to pass
instantiated
Review Comment:
Yes, using the same object is indeed convenient for testing. However, it
still acts as a backdoor. Perhaps we could shift this behavior out of
production and into the `GroupMetadataManagerTestContext`, allowing it to
override the `GroupCoordinatorConfig` to return the object directly. What do
you think?
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1905,7 +1718,7 @@ private
CoordinatorResult<ConsumerGroupHeartbeatResponseData, CoordinatorRecord>
metrics.record(CONSUMER_GROUP_REBALANCES_SENSOR_NAME);
}
- group.setMetadataRefreshDeadline(currentTimeMs +
consumerGroupMetadataRefreshIntervalMs, groupEpoch);
+ group.setMetadataRefreshDeadline(currentTimeMs +
Integer.MAX_VALUE, groupEpoch);
Review Comment:
It seems the "deadline" is a no-op due to `Integer.MAX_VALUE`, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
