peterxcli commented on PR #17991: URL: https://github.com/apache/kafka/pull/17991#issuecomment-2509129278
Hi @dengziming, The error in CI is cause by the expected error substring matching in `PlaintextAdminIntegrationTest#testValidIncrementalAlterConfigs`: https://github.com/apache/kafka/blob/0c9100dec571c6d73de78e19c4ed086620d1a152/core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala#L3237-L3239 To solve it, we can either make `assertFutureThrows`'s expected string to use containing check or just change the error string to the full error string "Invalid value zip for configuration compression.type: String must be one of: uncompressed, zstd, lz4, snappy, gzip, producer". Which approach do you think is better? Appreciate your thoughts. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
