chia7712 commented on code in PR #17957:
URL: https://github.com/apache/kafka/pull/17957#discussion_r1864993148
##########
core/src/test/java/kafka/server/share/SharePartitionTest.java:
##########
@@ -490,11 +490,14 @@ public void
testMaybeInitializeSharePartitionAgainConcurrentRequests() throws In
if (!executorService.awaitTermination(30, TimeUnit.MILLISECONDS))
executorService.shutdown();
}
+ int futuresCompleted = 0;
for (CompletableFuture<Void> result : results) {
assertTrue(result.isDone());
- assertFalse(result.isCompletedExceptionally());
+ if (!result.isCompletedExceptionally())
Review Comment:
The test appears to assume that all threads will successfully initialize the
share partition concurrently. However, due to the narrowed lock scope
introduced in this PR, some threads are now failing because the partition is in
the `INITIALIZING` state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
