satishd commented on code in PR #17959:
URL: https://github.com/apache/kafka/pull/17959#discussion_r1865469110
##########
storage/src/test/java/org/apache/kafka/tiered/storage/integration/OffloadAndTxnConsumeFromLeaderTest.java:
##########
@@ -97,7 +94,10 @@ protected void
writeTestSpecifications(TieredStorageTestBuilder builder) {
}
private static RemoteFetchCount getRemoteFetchCount() {
- FetchCountAndOp segmentFetchCountAndOp = new FetchCountAndOp(6,
EQUALS_TO);
+ // Ideally, each remote-log segment should be fetched only once. For 6
segments, we would have 6 fetch-counts.
+ // But, the client can retry the FETCH request, to make the test
deterministic, increasing the fetch-count
+ // to be at-max of 12 (2 times of fetch-count).
Review Comment:
This should remove the flakiness if the client retries in slower
environments like Jenkins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
