dajac commented on code in PR #17989:
URL: https://github.com/apache/kafka/pull/17989#discussion_r1865582471
##########
clients/src/main/java/org/apache/kafka/common/requests/ConsumerGroupHeartbeatRequest.java:
##########
@@ -59,6 +60,9 @@ public Builder(ConsumerGroupHeartbeatRequestData data,
boolean enableUnstableLas
@Override
public ConsumerGroupHeartbeatRequest build(short version) {
+ if (version == 0 && data.subscribedTopicRegex() != null) {
+ throw new UnsupportedVersionException("Broker does not support
resolution of SubscriptionPattern on version " + version);
Review Comment:
We need to check how we handle this error in the hb request manager. If I
recall correctly, we assume that the protocol is not supported when we get it.
It may be confusing.
I also note that we actually handle UNSUPPORTED_VERSION in the
AbstractHeartbeatRequestManager and the error message is specific to the
consumer group hb request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
