splett2 commented on code in PR #18009:
URL: https://github.com/apache/kafka/pull/18009#discussion_r1866734187
##########
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java:
##########
@@ -306,8 +306,11 @@ ReplicaPlacer replicaPlacer() {
*/
public void activate() {
heartbeatManager = new BrokerHeartbeatManager(logContext, time,
sessionTimeoutNs);
+ long nowNs = time.nanoseconds();
for (BrokerRegistration registration : brokerRegistrations.values()) {
heartbeatManager.register(registration.id(),
registration.fenced());
+ heartbeatManager.tracker().updateContactTime(
+ new BrokerIdAndEpoch(registration.id(), registration.epoch()),
nowNs);
Review Comment:
nit: may want to consider only adding unfenced brokers?
adding fenced brokers to the tracker may delay fencing a newly failed broker
by whatever is the session timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
