dongnuo123 commented on code in PR #17886:
URL: https://github.com/apache/kafka/pull/17886#discussion_r1868462457
##########
server-common/src/test/java/org/apache/kafka/server/common/FeaturesTest.java:
##########
@@ -24,21 +24,34 @@
import java.util.HashMap;
import java.util.Map;
+import static
org.apache.kafka.server.common.Features.validateDefaultValueAndLatestProductionValue;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;
public class FeaturesTest {
@ParameterizedTest
- @EnumSource(Features.class)
+ @EnumSource(value = Features.class, names = {
+ "UNIT_TEST_VERSION_0",
+ "UNIT_TEST_VERSION_1",
+ "UNIT_TEST_VERSION_2",
+ "UNIT_TEST_VERSION_3",
+ "UNIT_TEST_VERSION_4",
+ "UNIT_TEST_VERSION_5"}, mode = EnumSource.Mode.EXCLUDE)
Review Comment:
I don't quite follow. Doesn't this mean the test exclude the values provided
by `names`?
##########
server-common/src/test/java/org/apache/kafka/server/common/FeaturesTest.java:
##########
@@ -24,21 +24,34 @@
import java.util.HashMap;
import java.util.Map;
+import static
org.apache.kafka.server.common.Features.validateDefaultValueAndLatestProductionValue;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;
public class FeaturesTest {
@ParameterizedTest
- @EnumSource(Features.class)
+ @EnumSource(value = Features.class, names = {
+ "UNIT_TEST_VERSION_0",
+ "UNIT_TEST_VERSION_1",
+ "UNIT_TEST_VERSION_2",
+ "UNIT_TEST_VERSION_3",
+ "UNIT_TEST_VERSION_4",
+ "UNIT_TEST_VERSION_5"}, mode = EnumSource.Mode.EXCLUDE)
Review Comment:
I don't quite follow. Doesn't this mean the test excludes the values
provided by `names`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
