dajac commented on code in PR #18014:
URL: https://github.com/apache/kafka/pull/18014#discussion_r1869103917
##########
core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala:
##########
@@ -165,4 +166,21 @@ class CoordinatorPartitionWriter(
// Required offset.
partitionResult.lastOffset + 1
}
+
+ override def deleteRecords(tp: TopicPartition, deleteBeforeOffset: Long,
allowInternalTopicDeletion: Boolean): Unit = {
+ var deleteResults: Map[TopicPartition, DeleteRecordsPartitionResult] =
Map.empty
+ replicaManager.deleteRecords(
+ timeout = 0L,
+ offsetPerPartition = Map(tp -> deleteBeforeOffset),
+ responseCallback = results => deleteResults = results,
+ allowInternalTopicDeletion
Review Comment:
I wonder if we could just set it to `true` here as this class is only used
by the coordinator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
