cadonna commented on code in PR #18033:
URL: https://github.com/apache/kafka/pull/18033#discussion_r1869171812
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -841,6 +841,8 @@ public class StreamsConfig extends AbstractConfig {
public static final String
WINDOW_STORE_CHANGE_LOG_ADDITIONAL_RETENTION_MS_CONFIG =
"windowstore.changelog.additional.retention.ms";
private static final String
WINDOW_STORE_CHANGE_LOG_ADDITIONAL_RETENTION_MS_DOC = "Added to a windows
maintainMs to ensure data is not deleted from the log prematurely. Allows for
clock drift. Default is 1 day";
+ private static final String[] NOT_CONFIGURABLE_IN_GLOBAL_CONSUMER =
+ new String[] {ConsumerConfig.GROUP_PROTOCOL_CONFIG};
Review Comment:
Why is this needed for the global consumer but not for the restore consumer?
Both are manually assigned.
##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -841,6 +841,8 @@ public class StreamsConfig extends AbstractConfig {
public static final String
WINDOW_STORE_CHANGE_LOG_ADDITIONAL_RETENTION_MS_CONFIG =
"windowstore.changelog.additional.retention.ms";
private static final String
WINDOW_STORE_CHANGE_LOG_ADDITIONAL_RETENTION_MS_DOC = "Added to a windows
maintainMs to ensure data is not deleted from the log prematurely. Allows for
clock drift. Default is 1 day";
+ private static final String[] NOT_CONFIGURABLE_IN_GLOBAL_CONSUMER =
+ new String[] {ConsumerConfig.GROUP_PROTOCOL_CONFIG};
Review Comment:
Ah, I think I misunderstood. You did not mean the global consumer here, did
you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
