lucasbru commented on code in PR #18043:
URL: https://github.com/apache/kafka/pull/18043#discussion_r1870800560
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/StreamsGroup.java:
##########
@@ -251,7 +249,7 @@ public String stateAsString(long committedOffset) {
public ListGroupsResponseData.ListedGroup asListedGroup(long
committedOffset) {
return new ListGroupsResponseData.ListedGroup()
.setGroupId(groupId)
- .setProtocolType(ConsumerProtocol.PROTOCOL_TYPE)
+ .setProtocolType("streams")
Review Comment:
I think for classic groups, there is more than one protocol (consumer, sr,
connect...) but for streams groups, there is only a single protocol, that's why
I added a literal here. So for a single value, not sure if an enum makes sense.
But we could move it to a static constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
