apoorvmittal10 commented on PR #18053: URL: https://github.com/apache/kafka/pull/18053#issuecomment-2520066361
> Thanks for the PR. I think I've seen a deadlock similar to the code this is updating, so it would be good to fix this area before 4.0. I could be wrong but I doubt this PR will solve any potential deadlocks happeing currently, we should investigate the deadlock if it's occurring elsewhere. I would be glad if this PR solves the deadlock but I doubt. Regarding concern [here](https://github.com/apache/kafka/pull/17957#discussion_r1869445168), I think we are talking about a scenario which might occur when some additional changes are made and additional locks are held for `original` request future. I don't recommend doing these changes unless we see some issue in current code. We anyways will go through some refactoring in 4.1 where I would prefer to attain more granular locks to increase performance in Share Partition. @chia7712 please let me know if you think otherwise and think this can be a bottleneck. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
