mjsax commented on code in PR #17973:
URL: https://github.com/apache/kafka/pull/17973#discussion_r1872609044
##########
streams/src/main/java/org/apache/kafka/streams/kstream/Consumed.java:
##########
@@ -99,8 +99,8 @@ protected Consumed(final Consumed<K, V> consumed) {
public static <K, V> Consumed<K, V> with(final Serde<K> keySerde,
final Serde<V> valueSerde,
final TimestampExtractor
timestampExtractor,
- final Topology.AutoOffsetReset
resetPolicy) {
Review Comment:
> we will have two 'versions', the original (which I am to deprecate), and
the newer one I've implemented?
Correct.
> Why was the way I did this incorrect?
We need to preserve backward compatibility. If there is an existing Kafka
Streams program using eg 3.9 release, users should be able to just change the
dependency from 3.9 to 4.0, and recompile their program w/o the need to change
any code. -- If we would apply the change as you did it originally however,
their code would not compile any longer (if the use this method), and changes
to their program would be necessary to compile using Kafka Streams 4.0, and
thus it would be an breaking change, and we cannot have any breaking changes.
Does this make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
