apoorvmittal10 commented on code in PR #18093:
URL: https://github.com/apache/kafka/pull/18093#discussion_r1874535081
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -371,52 +370,35 @@ public static RecordState forId(byte id) {
*/
public CompletableFuture<Void> maybeInitialize() {
log.debug("Maybe initialize share partition: {}-{}", groupId,
topicIdPartition);
- CompletableFuture<Void> future = new CompletableFuture<>();
- AtomicReference<Optional<Throwable>> futureException = new
AtomicReference<>(Optional.empty());
// Check if the share partition is already initialized.
- InitializationResult initializationResult =
checkInitializationCompletion();
- if (initializationResult.isComplete()) {
- if (initializationResult.throwable() != null) {
- future.completeExceptionally(initializationResult.throwable());
- } else {
- future.complete(null);
+ try {
+ if (initializedOrThrowException()) {
+ return CompletableFuture.completedFuture(null);
}
- return future;
+ } catch (Exception e) {
+ return CompletableFuture.failedFuture(e);
}
+ // If code reaches here then the share partition is not initialized.
Initialize the share partition.
// All the pending requests should wait to get completed before the
share partition is initialized.
// Attain lock to avoid any concurrent requests to be processed.
lock.writeLock().lock();
- boolean shouldFutureBeCompleted = false;
try {
// Re-check the state to verify if previous requests has already
initialized the share partition.
- initializationResult = checkInitializationCompletion();
- if (initializationResult.isComplete()) {
- if (initializationResult.throwable() != null) {
-
futureException.set(Optional.of(initializationResult.throwable()));
- }
- shouldFutureBeCompleted = true;
- return future;
+ if (initializedOrThrowException()) {
+ return CompletableFuture.completedFuture(null);
Review Comment:
> finally will execute despite a return being present in try and catch
True, I am not understanding what's the problem here. It would be
synchronous execution in the same thread. Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
