jeffkbkim commented on code in PR #18086:
URL: https://github.com/apache/kafka/pull/18086#discussion_r1876536108
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -2608,12 +2608,16 @@ class KafkaApis(val requestChannel: RequestChannel,
addResultAndMaybeSendResponse(addPartitionsToTxnRequest.errorResponseForTransaction(transactionalId,
finalError))
}
+ // If the request is greater than version 4, we know the client
supports transaction version 2.
+ val clientTransactionVersion = if
(addPartitionsToTxnRequest.version() > 4) TransactionVersion.TV_2 else
TransactionVersion.TV_0
Review Comment:
nit: should we move this to TransactionVersion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
