ableegoldman commented on code in PR #18048:
URL: https://github.com/apache/kafka/pull/18048#discussion_r1877003569
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/KTableKTableJoinNode.java:
##########
@@ -120,30 +115,13 @@ private void enableVersionedSemantics(final
ProcessorParameters<K, ?, ?, ?> proc
public void writeToTopology(final InternalTopologyBuilder topologyBuilder)
{
final String thisProcessorName =
thisProcessorParameters().processorName();
final String otherProcessorName =
otherProcessorParameters().processorName();
- final String mergeProcessorName =
mergeProcessorParameters().processorName();
- topologyBuilder.addProcessor(
- thisProcessorName,
- thisProcessorParameters().processorSupplier(),
- thisJoinSideNodeName());
-
- topologyBuilder.addProcessor(
- otherProcessorName,
- otherProcessorParameters().processorSupplier(),
- otherJoinSideNodeName());
-
- topologyBuilder.addProcessor(
- mergeProcessorName,
- mergeProcessorParameters().processorSupplier(),
- thisProcessorName,
- otherProcessorName);
+ thisProcessorParameters().addProcessorTo(topologyBuilder,
thisJoinSideNodeName());
+ otherProcessorParameters().addProcessorTo(topologyBuilder,
otherJoinSideNodeName());
+ mergeProcessorParameters().addProcessorTo(topologyBuilder,
thisProcessorName, otherProcessorName);
topologyBuilder.connectProcessorAndStateStores(thisProcessorName,
joinOtherStoreNames);
topologyBuilder.connectProcessorAndStateStores(otherProcessorName,
joinThisStoreNames);
Review Comment:
we should be able to remove these. I would actually consider it a bug if we
were to remove these and the tests didn't pass -- since #addProcessorTo should
call #addStateStore which should call #connectProcessorAndStateStores
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
