chia7712 commented on code in PR #16754:
URL: https://github.com/apache/kafka/pull/16754#discussion_r1877503804
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/HerderRequestHandler.java:
##########
@@ -113,6 +113,7 @@ public <T, U> T completeOrForwardRequest(FutureCallback<T>
cb,
}
String forwardUrl = uriBuilder.build().toString();
log.debug("Forwarding request {} {} {}", forwardUrl, method,
body);
+ // TODO, we may need to set the reqest timeout as Idle timeout
on the HttpClient
Review Comment:
typo: `reqest` -> `request`
##########
gradle/dependencies.gradle:
##########
@@ -162,15 +163,16 @@ libs += [
jacksonModuleScala:
"com.fasterxml.jackson.module:jackson-module-scala_$versions.baseScala:$versions.jackson",
jacksonJDK8Datatypes:
"com.fasterxml.jackson.datatype:jackson-datatype-jdk8:$versions.jackson",
jacksonBlackbird:
"com.fasterxml.jackson.module:jackson-module-blackbird:$versions.jackson",
- jacksonJaxrsJsonProvider:
"com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider:$versions.jackson",
+ jacksonJakartarsJsonProvider:
"com.fasterxml.jackson.jakarta.rs:jackson-jakarta-rs-json-provider:$versions.jackson",
jaxAnnotationApi:
"javax.annotation:javax.annotation-api:$versions.jaxAnnotation",
jaxbApi: "javax.xml.bind:jaxb-api:$versions.jaxb",
- jaxrsApi: "javax.ws.rs:javax.ws.rs-api:$versions.jaxrs",
+ jakartaRsApi: "jakarta.ws.rs:jakarta.ws.rs-api:$versions.jakartaRs",
+ jakartaServletApi:
"jakarta.servlet:jakarta.servlet-api:$versions.jakartaServlet",
Review Comment:
`jetty` 12.0.15 is using `jakarta.servlet` 6.0.0, so maybe we can remove
this unused declaration?
##########
gradle/dependencies.gradle:
##########
@@ -162,15 +163,16 @@ libs += [
jacksonModuleScala:
"com.fasterxml.jackson.module:jackson-module-scala_$versions.baseScala:$versions.jackson",
jacksonJDK8Datatypes:
"com.fasterxml.jackson.datatype:jackson-datatype-jdk8:$versions.jackson",
jacksonBlackbird:
"com.fasterxml.jackson.module:jackson-module-blackbird:$versions.jackson",
- jacksonJaxrsJsonProvider:
"com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider:$versions.jackson",
+ jacksonJakartarsJsonProvider:
"com.fasterxml.jackson.jakarta.rs:jackson-jakarta-rs-json-provider:$versions.jackson",
jaxAnnotationApi:
"javax.annotation:javax.annotation-api:$versions.jaxAnnotation",
jaxbApi: "javax.xml.bind:jaxb-api:$versions.jaxb",
- jaxrsApi: "javax.ws.rs:javax.ws.rs-api:$versions.jaxrs",
+ jakartaRsApi: "jakarta.ws.rs:jakarta.ws.rs-api:$versions.jakartaRs",
Review Comment:
Could you please remove unnecessary item from license file after this change?
https://github.com/apache/kafka/blob/633cab91c1d5ca80763103fa38fb778dcf545709/LICENSE-binary#L305
Also, the following rule seems to be unnecessary.
https://github.com/apache/kafka/blob/trunk/build.gradle#L2900
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/HerderRequestHandler.java:
##########
@@ -113,6 +113,7 @@ public <T, U> T completeOrForwardRequest(FutureCallback<T>
cb,
}
String forwardUrl = uriBuilder.build().toString();
log.debug("Forwarding request {} {} {}", forwardUrl, method,
body);
+ // TODO, we may need to set the reqest timeout as Idle timeout
on the HttpClient
Review Comment:
This comment is valid to me, as the default idle timeout for HttpClient is
30 seconds, and the default request timeout is 90 seconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
