Serwios commented on code in PR #18130:
URL: https://github.com/apache/kafka/pull/18130#discussion_r1878875515


##########
clients/src/main/java/org/apache/kafka/server/authorizer/Authorizer.java:
##########
@@ -182,114 +171,6 @@ default int aclCount() {
      *                       given type. Return {@link 
AuthorizationResult#DENIED} otherwise.
      */
     default AuthorizationResult 
authorizeByResourceType(AuthorizableRequestContext requestContext, AclOperation 
op, ResourceType resourceType) {
-        SecurityUtils.authorizeByResourceTypeCheckArgs(op, resourceType);
-
-        // Check a hard-coded name to ensure that super users are granted

Review Comment:
   I removed comment's as thet seems to be redunant when code is self 
secriptive by separated methods 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to