mjsax commented on code in PR #17973:
URL: https://github.com/apache/kafka/pull/17973#discussion_r1879107930
##########
streams/src/main/java/org/apache/kafka/streams/Topology.java:
##########
@@ -252,6 +325,27 @@ public synchronized Topology addSource(final
AutoOffsetReset offsetReset,
return this;
}
+ /**
+ * Adds a new source that consumes from topics matching the given pattern
with a specified {@link TimestampExtractor}
+ * and forwards the records to child processor and/or sink nodes.
+ * The source will use the provided timestamp extractor to determine the
timestamp of each record.
+ *
+ * @param offsetReset the auto offset reset policy to use if no committed
offsets are found
+ * @param timestampExtractor the timestamp extractor to use for this source
+ * @param name the unique name of the source used to reference this node
when {@link #addProcessor(String, ProcessorSupplier, String...) adding
processor children}
+ * @param topicPattern the regular expression pattern to match Kafka
topics that this source is to consume
+ * @return itself
+ * @throws TopologyException if a processor is already added or if topics
have already been registered by another source
+ */
+ public synchronized Topology addSource(final
org.apache.kafka.streams.AutoOffsetReset offsetReset,
Review Comment:
That does not work, as we are inside `Topology` class itself... So we can
only refer to the new class via the the fully qualified name, and for the
existing enum, if does not by us anything to use the full path as we are in the
right scope anyway (and we need to use the full path for the new class anyway)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
