ableegoldman commented on code in PR #18111:
URL: https://github.com/apache/kafka/pull/18111#discussion_r1879325001
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java:
##########
@@ -209,19 +209,13 @@ public <K, V1, V2, VOut> KStream<K, VOut> join(final
KStream<K, V1> lhs,
joinBuilder.withJoinMergeProcessorParameters(joinMergeProcessorParams)
.withJoinThisProcessorParameters(joinThisProcessorParams)
.withJoinOtherProcessorParameters(joinOtherProcessorParams)
- .withThisWindowStoreBuilder(thisWindowStore)
- .withOtherWindowStoreBuilder(otherWindowStore)
-
.withThisWindowedStreamProcessorParameters(thisWindowStreamProcessorParams)
-
.withOtherWindowedStreamProcessorParameters(otherWindowStreamProcessorParams)
+
.withThisWindowedStreamProcessorName(thisWindowStreamProcessorParams.processorName())
+
.withOtherWindowedStreamProcessorName(otherWindowStreamProcessorParams.processorName())
.withOuterJoinWindowStoreBuilder(outerJoinWindowStore)
Review Comment:
Ah, I actually did already move it to the processors but forgot to remove it
from here as well. Good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
