divijvaidya commented on code in PR #18106:
URL: https://github.com/apache/kafka/pull/18106#discussion_r1880379220
##########
docs/upgrade.html:
##########
@@ -211,6 +211,16 @@ <h5><a id="upgrade_400_notable"
href="#upgrade_400_notable">Notable changes in 4
been updated to enable the replication of topics that
appear to be internal but aren't truly internal to Kafka and Mirror Maker 2.
See <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1074%3A+Allow+the+replication+of+user+internal+topics";>KIP-1074</a>
for more details.
</li>
+ <li>
+ The default value of 'num.recovery.threads.per.data.dir'
has been changed from 1 to 2. The impact of this is faster
+ recovery post unclean shutdown at the expense of extra IO
cycles.
+ See <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1030%3A+Change+constraints+and+default+values+for+various+configurations";>KIP-1030</a>
+ </li>
+ <li>
+ The default value of 'message.timestamp.after.max.ms' has
been changed from Long.Max to 1 hour. The impact of this messages with a
Review Comment:
Also, please mention (and the corresponding broker level config) -
`log.message.timestamp.after.max.ms`
##########
docs/upgrade.html:
##########
@@ -211,6 +211,16 @@ <h5><a id="upgrade_400_notable"
href="#upgrade_400_notable">Notable changes in 4
been updated to enable the replication of topics that
appear to be internal but aren't truly internal to Kafka and Mirror Maker 2.
See <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1074%3A+Allow+the+replication+of+user+internal+topics";>KIP-1074</a>
for more details.
</li>
+ <li>
+ The default value of 'num.recovery.threads.per.data.dir'
has been changed from 1 to 2. The impact of this is faster
Review Comment:
this belong to a different PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
