mjsax commented on code in PR #18154:
URL: https://github.com/apache/kafka/pull/18154#discussion_r1881322995
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorTopologyTest.java:
##########
@@ -1568,21 +1105,19 @@ private Topology
createSimpleTopologyWithDroppingPartitioner() {
.addSink("sink", OUTPUT_TOPIC_1, new DroppingPartitioner(),
"processor");
}
- @Deprecated // testing old PAPI
Review Comment:
This annotation was wrong -- should have been
`@SuppressWarning("deprecation")`
Updating this code to use new Processor API now.
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/ProcessorTopologyTest.java:
##########
@@ -1568,21 +1105,19 @@ private Topology
createSimpleTopologyWithDroppingPartitioner() {
.addSink("sink", OUTPUT_TOPIC_1, new DroppingPartitioner(),
"processor");
}
- @Deprecated // testing old PAPI
private Topology createStatefulTopology(final String storeName) {
return topology
.addSource("source", STRING_DESERIALIZER, STRING_DESERIALIZER,
INPUT_TOPIC_1)
- .addProcessor("processor", define(new
OldAPIStatefulProcessor(storeName)), "source")
+ .addProcessor("processor", () -> new StatefulProcessor(storeName),
"source")
.addStateStore(Stores.keyValueStoreBuilder(Stores.inMemoryKeyValueStore(storeName),
Serdes.String(), Serdes.String()), "processor")
.addSink("counts", OUTPUT_TOPIC_1, "processor");
}
- @Deprecated // testing old PAPI
Review Comment:
as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
