squah-confluent commented on code in PR #18127:
URL: https://github.com/apache/kafka/pull/18127#discussion_r1881395374
##########
clients/src/test/resources/common/message/StructMessage.json:
##########
@@ -13,7 +13,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.
{
- "name": "NullableStructMessage",
+ "name": "StructMessage",
Review Comment:
Now that I've address the other review comment, the rename no longer makes
sense.
`SimpleExampleMessageTest` and `NullableMessageTest` exercise all
combinations of {non-tagged, tagged}x{non-nullable, nullable} structs, so
adding a size assert to both those classes is simpler.
That just leaves the particular 127-long tagged nullable struct edge case.
I've left the test for that in `NullableMessageTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
