AndrewJSchofield commented on PR #18101: URL: https://github.com/apache/kafka/pull/18101#issuecomment-2539728469
@peterxcli It seems to me that this doesn't quite work as well as it might. In my testing, connecting a share consumer to a broker which does not support `SHARE_GROUP_HEARTBEAT` does not emit the new message. What actually happens is that `org.apache.kafka.common.errors.UnsupportedVersionException: The node does not support SHARE_GROUP_HEARTBEAT` is thrown. The consumer checks the ApiVersions response and notices that `SHARE_GROUP_HEARTBEAT` is not supported before it's even sent a request. As a result, in `AbstractHeartbeatRequestManager.makeHeartbeatRequest`, in the `whenComplete` call, the response is null. This means we end up in `onFailure` rather than `onResponse`, and this means the new code is never actually executed. What do you think @lianetm? Am I missing something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
