lianetm commented on code in PR #18160:
URL: https://github.com/apache/kafka/pull/18160#discussion_r1882858331
##########
tools/src/test/java/org/apache/kafka/tools/AbstractResetIntegrationTest.java:
##########
@@ -406,6 +408,7 @@ protected boolean tryCleanGlobal(final boolean
withIntermediateTopics,
final Properties cleanUpConfig = new Properties();
cleanUpConfig.put(ConsumerConfig.HEARTBEAT_INTERVAL_MS_CONFIG, 100);
cleanUpConfig.put(ConsumerConfig.SESSION_TIMEOUT_MS_CONFIG,
Integer.toString(CLEANUP_CONSUMER_TIMEOUT));
+ cleanUpConfig.put(ConsumerConfig.GROUP_PROTOCOL_CONFIG,
GroupProtocol.CLASSIC.name);
Review Comment:
perfect, we're on the same page then, guarding against CONSUMER (not against
setting CLASSIC explicitly). And agree on removing the unneeded line in the
test. Will open a follow-up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
