rodesai commented on code in PR #18155:
URL: https://github.com/apache/kafka/pull/18155#discussion_r1883467851
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/TableProcessorNode.java:
##########
@@ -62,21 +62,25 @@ public String toString() {
@SuppressWarnings("unchecked")
@Override
public void writeToTopology(final InternalTopologyBuilder topologyBuilder)
{
+ processorParameters.addProcessorTo(topologyBuilder, parentNodeNames());
+
final String processorName = processorParameters.processorName();
- topologyBuilder.addProcessor(processorName,
processorParameters.processorSupplier(), parentNodeNames());
if (storeNames.length > 0) {
+ // todo(rodesai): remove me once all operators have been moved to
ProcessorSupplier
topologyBuilder.connectProcessorAndStateStores(processorName,
storeNames);
}
final KTableSource<K, V> tableSource =
processorParameters.processorSupplier() instanceof KTableSource ?
(KTableSource<K, V>) processorParameters.processorSupplier() :
null;
if (tableSource != null) {
+ // todo(rodesai): remove once KTableImpl#doJoinOnForeignKey moved
to ProcessorSupplier
if (tableSource.materialized()) {
topologyBuilder.addStateStore(Objects.requireNonNull(storeFactory,
"storeFactory was null"),
processorName);
}
Review Comment:
tests pass! I'll update the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
