cmccabe commented on PR #15622: URL: https://github.com/apache/kafka/pull/15622#issuecomment-2542408612
I was a bit confused by this PR since I thought that it was going to be about setting a threshold (like 5 seconds or something) and saying that any event that lasted longer than that was so bad, so egregious, that it should always be logged. (Tangent: I still actually do think we should do that!) But instead this is more like having a background process gathering stats. Which is actually quite useful in its own way. Question, though: why can't we set the logging interval to 60 seconds and just log the longest event unconditionally? It's not that much noise and people can turn it off if they want to. There's probably a bunch of other stuff we could do like try to get the "top 5" rather than just the top event. But we can always do that in a follow-on, no need to block this one. I think we should rename `SlowEventsLogger` since it's more about general performance stats and not just about slow events. Also calling it "logger" sort of makes it sound like part of log4j. Perhaps call it `EventPerformanceMonitor`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
