lhunyady commented on code in PR #16520:
URL: https://github.com/apache/kafka/pull/16520#discussion_r1886719584
##########
tests/kafkatest/services/connect.py:
##########
@@ -432,9 +482,14 @@ def start_node(self, node, **kwargs):
self.start_and_return_immediately(node, 'distributed', '')
elif self.startup_mode == self.STARTUP_MODE_LISTEN:
self.start_and_wait_to_start_listening(node, 'distributed', '')
- else:
- # The default mode is to wait until the complete startup of the
worker
+ elif self.startup_mode == self.STARTUP_MODE_JOIN:
self.start_and_wait_to_join_group(node, 'distributed', '')
+ elif self.startup_mode is None or self.startup_mode ==
self.STARTUP_MODE_HEALTH_CHECK:
Review Comment:
nit: This start_node method is pretty similar in both
ConnectDistributedService and ConnectStandaloneService, maybe the common parts
should be in the ConnectServiceBase with a template method for the
connector_config_templates processing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
