gharris1727 commented on code in PR #17742:
URL: https://github.com/apache/kafka/pull/17742#discussion_r1887268918
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java:
##########
@@ -594,12 +609,15 @@ void enrich(ConfigDef newDef) {
int orderInGroup = 0;
final String typeConfig = prefix + "type";
+ final String versionConfig = prefix +
WorkerConfig.PLUGIN_VERSION_SUFFIX;
+
+ // Add the class configuration
final ConfigDef.Validator typeValidator =
ConfigDef.LambdaValidator.with(
(String name, Object value) -> {
validateProps(prefix);
// The value will be null if the class couldn't be
found; no point in performing follow-up validation
if (value != null) {
-
getConfigDefFromConfigProvidingClass(typeConfig, (Class<?>) value);
+ getConfigDefFromPlugin(typeConfig, ((Class<?>)
value).getName(), null, plugins);
Review Comment:
I think this validator needs to include the error when the version is
incorrect, similar to the converters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
