ahuang98 commented on code in PR #16831:
URL: https://github.com/apache/kafka/pull/16831#discussion_r1889111428
##########
raft/src/test/java/org/apache/kafka/raft/KafkaNetworkChannelTest.java:
##########
@@ -288,7 +290,7 @@ private ApiMessage buildTestRequest(ApiKeys key) {
return VoteRequest.singletonRequest(topicPartition, clusterId,
leaderEpoch, leaderId, lastEpoch, 329);
case FETCH:
- FetchRequestData request =
RaftUtil.singletonFetchRequest(topicPartition, topicId, fetchPartition ->
+ FetchRequestData request =
FetchRpc.singletonFetchRequest(topicPartition, topicId, fetchPartition ->
Review Comment:
I wouldn't be upset having both Fetch and FetchSnapshot in the same class.
But I guess same argument could be made for Begin and End Quorum (and I see how
naming might get more difficult)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
