mumrah commented on code in PR #18183:
URL: https://github.com/apache/kafka/pull/18183#discussion_r1890562099
##########
.github/workflows/build.yml:
##########
@@ -137,6 +137,17 @@ jobs:
run: python .github/scripts/rat.py
env:
GITHUB_WORKSPACE: ${{ github.workspace }}
+ - name: Check generated documentation
+ if: always()
Review Comment:
Hm, `always()` means this will run even if a previous step failed. Maybe we
should remove this so the step is not run in the event that the "Compile and
validate" step fails.
##########
.github/workflows/build.yml:
##########
@@ -137,6 +137,17 @@ jobs:
run: python .github/scripts/rat.py
env:
GITHUB_WORKSPACE: ${{ github.workspace }}
+ - name: Check generated documentation
+ if: always()
+ # Check if there are any empty files under ./site-docs/generated, If
any empty files are found, print an error
+ # message and list the empty files
+ run: |
+ tar zxvf core/build/distributions/kafka_2.13-$(./gradlew properties
| grep version: | awk '{print $NF}' | head -n 1)-site-docs.tgz
+ if find ./site-docs/generated -type f -exec grep -L "." {} \; | grep
-q "."; then
+ echo "One or more documentation files are empty!" >&2
+ find ./site-docs/generated -type f -exec grep -L "." {} \; >&2
+ exit 1
Review Comment:
Can you indent the `if` body by 2 spaces?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
