mjsax commented on code in PR #18124:
URL: https://github.com/apache/kafka/pull/18124#discussion_r1891008146
##########
docs/streams/upgrade-guide.html:
##########
@@ -141,6 +141,22 @@ <h3 class="anchor-heading"><a id="streams_notable_changes"
class="anchor-link"><
<h3><a id="streams_api_changes_400"
href="#streams_api_changes_400">Streams API changes in 4.0.0</a></h3>
+ <p>
+ In this release, eos-v1 (Exactly Once Semantics version 1) is no
longer supported. Additionally, all deprecated methods, classes, APIs, and
config parameters
+ up to (including) AK 3.5 release have been removed.
+ </p>
+
+ <p>
+ For better observability and performance, analysis are provided by
additional metrics in Kafka clients and new methods added to the Admin,
Review Comment:
Why do we have this paragraph? Seem all KIPs are listed individually below?
##########
docs/streams/upgrade-guide.html:
##########
@@ -161,6 +177,65 @@ <h3><a id="streams_api_changes_400"
href="#streams_api_changes_400">Streams API
<code>TransformerSupplier</code>, <code>ValueTransformer</code>, and
<code>ValueTransformerSupplier</code>.
</p>
+ <p>
+ Kafka Streams introduced the <code>RETRY</code> return option the
<code>ProductionExceptionHandler</code> (<a
href="https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=311627309";>KIP-1065</a>).
+ This feature addresses the issue of infinite retry loops caused by
<code>TimeoutException</code> when an output topic might be missing.
+ Now the application is enabled to attempt the action again instead of
either crashing or dropping records.
+ This change aims to enhance the robustness and reliability of Kafka
Streams by providing a more flexible error-handling mechanism.
+ </p>
+
+ <p>
+
+ </p>
+ <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1076%3A++Metrics+for+client+applications+KIP-714+extension";>KIP-1076</a>
+ proposes adding methods to the Admin, Consumer, and Producer
interfaces to allow applications embedding Kafka clients to register and push
application-specific metrics,
+ supplementing the client metrics introduced in KIP-714.
+
+ <p>
+ <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1077%3A+Deprecate+%60ForeachProcessor%60+and+move+to+internal+package";>KIP-1077</a>
+ deprecates the <code>ForeachProcessor</code> class and move it to an
internal package.
+ This change is aimed at improving the organization and clarity of the
Kafka Streams API by ensuring that internal classes are not exposed in public
packages.
+ </p>
+
+ <p>
+ <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1078%3A+Remove+Leaking+Getter+Methods+in+Joined+Helper+Class";>KIP-1078</a>
deprecates the leaking getter methods in the <code>Joined</code> helper class.
+ These methods should be deprecated for future removal as they are
already available via <code>JoinedInternal</code> class.
+ </p>
+
+ <p>
+ To ensures better encapsulation and organization of configuration
documentation within Kafka Streams,
+ <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1085%3A+Fix+leaking+*_DOC+variables+in+StreamsConfig";>KIP-1085</a>
+ deprecate certain public doc description variables that are only used
within the <code>StreamsConfig</code> or <code>TopologyConfig</code> classes.
+ Additionally, the unused variable <code>DUMMY_THREAD_INDEX</code> will
also be deprecated.
+ </p>
+
+ <p>
+ Due to the recent deprecation of the <code>#through</code> method in
Kafka Streams, the <code>intermediateTopicsOption</code> of
<code>StreamsResetter</code> tool in Apache Kafka is
Review Comment:
```suggestion
Due to the removal of the already deprecated <code>#through</code>
method in Kafka Streams, the <code>intermediateTopicsOption</code> of
<code>StreamsResetter</code> tool in Apache Kafka is
```
##########
docs/streams/upgrade-guide.html:
##########
@@ -161,6 +177,65 @@ <h3><a id="streams_api_changes_400"
href="#streams_api_changes_400">Streams API
<code>TransformerSupplier</code>, <code>ValueTransformer</code>, and
<code>ValueTransformerSupplier</code>.
</p>
+ <p>
+ Kafka Streams introduced the <code>RETRY</code> return option the
<code>ProductionExceptionHandler</code> (<a
href="https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=311627309";>KIP-1065</a>).
+ This feature addresses the issue of infinite retry loops caused by
<code>TimeoutException</code> when an output topic might be missing.
+ Now the application is enabled to attempt the action again instead of
either crashing or dropping records.
+ This change aims to enhance the robustness and reliability of Kafka
Streams by providing a more flexible error-handling mechanism.
+ </p>
+
+ <p>
+
+ </p>
+ <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1076%3A++Metrics+for+client+applications+KIP-714+extension";>KIP-1076</a>
+ proposes adding methods to the Admin, Consumer, and Producer
interfaces to allow applications embedding Kafka clients to register and push
application-specific metrics,
+ supplementing the client metrics introduced in KIP-714.
Review Comment:
> the client metrics introduced in
KIP-714 did not introduce new metrics IIRC (and even if, it would not be the
point, right?) -- the KIP is about collection client metrics broker side.
##########
docs/streams/upgrade-guide.html:
##########
@@ -161,6 +177,65 @@ <h3><a id="streams_api_changes_400"
href="#streams_api_changes_400">Streams API
<code>TransformerSupplier</code>, <code>ValueTransformer</code>, and
<code>ValueTransformerSupplier</code>.
</p>
+ <p>
+ Kafka Streams introduced the <code>RETRY</code> return option the
<code>ProductionExceptionHandler</code> (<a
href="https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=311627309";>KIP-1065</a>).
+ This feature addresses the issue of infinite retry loops caused by
<code>TimeoutException</code> when an output topic might be missing.
+ Now the application is enabled to attempt the action again instead of
either crashing or dropping records.
+ This change aims to enhance the robustness and reliability of Kafka
Streams by providing a more flexible error-handling mechanism.
+ </p>
+
+ <p>
+
+ </p>
+ <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1076%3A++Metrics+for+client+applications+KIP-714+extension";>KIP-1076</a>
+ proposes adding methods to the Admin, Consumer, and Producer
interfaces to allow applications embedding Kafka clients to register and push
application-specific metrics,
+ supplementing the client metrics introduced in KIP-714.
+
+ <p>
+ <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1077%3A+Deprecate+%60ForeachProcessor%60+and+move+to+internal+package";>KIP-1077</a>
+ deprecates the <code>ForeachProcessor</code> class and move it to an
internal package.
Review Comment:
```suggestion
deprecates the <code>ForeachProcessor</code> class.
```
##########
docs/streams/upgrade-guide.html:
##########
@@ -161,6 +177,65 @@ <h3><a id="streams_api_changes_400"
href="#streams_api_changes_400">Streams API
<code>TransformerSupplier</code>, <code>ValueTransformer</code>, and
<code>ValueTransformerSupplier</code>.
</p>
+ <p>
+ Kafka Streams introduced the <code>RETRY</code> return option the
<code>ProductionExceptionHandler</code> (<a
href="https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=311627309";>KIP-1065</a>).
+ This feature addresses the issue of infinite retry loops caused by
<code>TimeoutException</code> when an output topic might be missing.
+ Now the application is enabled to attempt the action again instead of
either crashing or dropping records.
Review Comment:
> Previously, the `ProductionExceptionHandler` was not invoked on a
(retriable) `TimeoutException`. With Kafka Streams 4.0, the handler is called,
and the default handler would return `RETRY` to not change existing behavior.
However, a custom handler can now decide to break the infinite retry loop by
returning either `CONTINUE` or `FAIL`.
##########
docs/streams/upgrade-guide.html:
##########
@@ -161,6 +177,65 @@ <h3><a id="streams_api_changes_400"
href="#streams_api_changes_400">Streams API
<code>TransformerSupplier</code>, <code>ValueTransformer</code>, and
<code>ValueTransformerSupplier</code>.
</p>
+ <p>
+ Kafka Streams introduced the <code>RETRY</code> return option the
<code>ProductionExceptionHandler</code> (<a
href="https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=311627309";>KIP-1065</a>).
+ This feature addresses the issue of infinite retry loops caused by
<code>TimeoutException</code> when an output topic might be missing.
Review Comment:
```suggestion
This feature addresses the issue of infinite retry loops caused by
<code>TimeoutException</code>, for example when an output topic does not exist.
```
##########
docs/streams/upgrade-guide.html:
##########
@@ -161,6 +177,65 @@ <h3><a id="streams_api_changes_400"
href="#streams_api_changes_400">Streams API
<code>TransformerSupplier</code>, <code>ValueTransformer</code>, and
<code>ValueTransformerSupplier</code>.
</p>
+ <p>
+ Kafka Streams introduced the <code>RETRY</code> return option the
<code>ProductionExceptionHandler</code> (<a
href="https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=311627309";>KIP-1065</a>).
+ This feature addresses the issue of infinite retry loops caused by
<code>TimeoutException</code> when an output topic might be missing.
+ Now the application is enabled to attempt the action again instead of
either crashing or dropping records.
+ This change aims to enhance the robustness and reliability of Kafka
Streams by providing a more flexible error-handling mechanism.
+ </p>
+
+ <p>
+
+ </p>
Review Comment:
This should go after the paragraph
##########
docs/streams/upgrade-guide.html:
##########
@@ -141,6 +141,22 @@ <h3 class="anchor-heading"><a id="streams_notable_changes"
class="anchor-link"><
<h3><a id="streams_api_changes_400"
href="#streams_api_changes_400">Streams API changes in 4.0.0</a></h3>
+ <p>
+ In this release, eos-v1 (Exactly Once Semantics version 1) is no
longer supported. Additionally, all deprecated methods, classes, APIs, and
config parameters
+ up to (including) AK 3.5 release have been removed.
Review Comment:
```suggestion
up to (including) Kafka Streams 3.6 release have been removed.
```
##########
docs/streams/upgrade-guide.html:
##########
@@ -161,6 +177,65 @@ <h3><a id="streams_api_changes_400"
href="#streams_api_changes_400">Streams API
<code>TransformerSupplier</code>, <code>ValueTransformer</code>, and
<code>ValueTransformerSupplier</code>.
</p>
+ <p>
+ Kafka Streams introduced the <code>RETRY</code> return option the
<code>ProductionExceptionHandler</code> (<a
href="https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=311627309";>KIP-1065</a>).
+ This feature addresses the issue of infinite retry loops caused by
<code>TimeoutException</code> when an output topic might be missing.
+ Now the application is enabled to attempt the action again instead of
either crashing or dropping records.
+ This change aims to enhance the robustness and reliability of Kafka
Streams by providing a more flexible error-handling mechanism.
+ </p>
+
+ <p>
+
+ </p>
+ <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1076%3A++Metrics+for+client+applications+KIP-714+extension";>KIP-1076</a>
+ proposes adding methods to the Admin, Consumer, and Producer
interfaces to allow applications embedding Kafka clients to register and push
application-specific metrics,
Review Comment:
```suggestion
adds new methods
<code>registerMetricForSubscription(KafkaMetric)</code> and
<code>unregisterMetricFromSubscription(KafkaMetric)</code> to the Admin,
Consumer, and Producer interfaces to allow applications embedding Kafka clients
to register application-specific metrics for pushing them to the broker,
```
##########
docs/streams/upgrade-guide.html:
##########
@@ -161,6 +177,65 @@ <h3><a id="streams_api_changes_400"
href="#streams_api_changes_400">Streams API
<code>TransformerSupplier</code>, <code>ValueTransformer</code>, and
<code>ValueTransformerSupplier</code>.
</p>
+ <p>
+ Kafka Streams introduced the <code>RETRY</code> return option the
<code>ProductionExceptionHandler</code> (<a
href="https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=311627309";>KIP-1065</a>).
+ This feature addresses the issue of infinite retry loops caused by
<code>TimeoutException</code> when an output topic might be missing.
+ Now the application is enabled to attempt the action again instead of
either crashing or dropping records.
+ This change aims to enhance the robustness and reliability of Kafka
Streams by providing a more flexible error-handling mechanism.
+ </p>
+
+ <p>
+
+ </p>
+ <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1076%3A++Metrics+for+client+applications+KIP-714+extension";>KIP-1076</a>
+ proposes adding methods to the Admin, Consumer, and Producer
interfaces to allow applications embedding Kafka clients to register and push
application-specific metrics,
+ supplementing the client metrics introduced in KIP-714.
+
+ <p>
+ <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1077%3A+Deprecate+%60ForeachProcessor%60+and+move+to+internal+package";>KIP-1077</a>
+ deprecates the <code>ForeachProcessor</code> class and move it to an
internal package.
+ This change is aimed at improving the organization and clarity of the
Kafka Streams API by ensuring that internal classes are not exposed in public
packages.
+ </p>
+
+ <p>
+ <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1078%3A+Remove+Leaking+Getter+Methods+in+Joined+Helper+Class";>KIP-1078</a>
deprecates the leaking getter methods in the <code>Joined</code> helper class.
+ These methods should be deprecated for future removal as they are
already available via <code>JoinedInternal</code> class.
+ </p>
+
+ <p>
+ To ensures better encapsulation and organization of configuration
documentation within Kafka Streams,
+ <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1085%3A+Fix+leaking+*_DOC+variables+in+StreamsConfig";>KIP-1085</a>
+ deprecate certain public doc description variables that are only used
within the <code>StreamsConfig</code> or <code>TopologyConfig</code> classes.
+ Additionally, the unused variable <code>DUMMY_THREAD_INDEX</code> will
also be deprecated.
+ </p>
+
+ <p>
+ Due to the recent deprecation of the <code>#through</code> method in
Kafka Streams, the <code>intermediateTopicsOption</code> of
<code>StreamsResetter</code> tool in Apache Kafka is
+ not needed any more and therefore is deprecated (<a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1087%3A+Removing+intermediateTopicsOption+from+StreamsResetter";>KIP-1087</a>).
+ </p>
+
+ <p>
+ In this release, explicit status information about the application's
health is provided by new numeric metrics for both client-level and
thread-level states
+ (<a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1091%3A+Improved+Kafka+Streams+operator+metrics";>KIP-1091</a>).
+ These metrics will be available at the <code>INFO</code> recording
level, and a thread-level metric with a String value will be available for
users leveraging Java Management Extensions (<code>JMX</code>).
+ </p>
Review Comment:
Might be good to mention the motivation? The existing metrics cannot be
collected via KIP-714, so we introduce numeric counterparts to allow proper
broker side metric collection for KS apps.
##########
docs/streams/upgrade-guide.html:
##########
@@ -161,6 +177,65 @@ <h3><a id="streams_api_changes_400"
href="#streams_api_changes_400">Streams API
<code>TransformerSupplier</code>, <code>ValueTransformer</code>, and
<code>ValueTransformerSupplier</code>.
</p>
+ <p>
+ Kafka Streams introduced the <code>RETRY</code> return option the
<code>ProductionExceptionHandler</code> (<a
href="https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=311627309";>KIP-1065</a>).
+ This feature addresses the issue of infinite retry loops caused by
<code>TimeoutException</code> when an output topic might be missing.
+ Now the application is enabled to attempt the action again instead of
either crashing or dropping records.
+ This change aims to enhance the robustness and reliability of Kafka
Streams by providing a more flexible error-handling mechanism.
+ </p>
+
+ <p>
+
+ </p>
+ <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1076%3A++Metrics+for+client+applications+KIP-714+extension";>KIP-1076</a>
+ proposes adding methods to the Admin, Consumer, and Producer
interfaces to allow applications embedding Kafka clients to register and push
application-specific metrics,
+ supplementing the client metrics introduced in KIP-714.
+
+ <p>
+ <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1077%3A+Deprecate+%60ForeachProcessor%60+and+move+to+internal+package";>KIP-1077</a>
+ deprecates the <code>ForeachProcessor</code> class and move it to an
internal package.
+ This change is aimed at improving the organization and clarity of the
Kafka Streams API by ensuring that internal classes are not exposed in public
packages.
+ </p>
+
+ <p>
+ <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1078%3A+Remove+Leaking+Getter+Methods+in+Joined+Helper+Class";>KIP-1078</a>
deprecates the leaking getter methods in the <code>Joined</code> helper class.
+ These methods should be deprecated for future removal as they are
already available via <code>JoinedInternal</code> class.
Review Comment:
```suggestion
These methods are deprecated without a replacement for future
removal, as they don't add any value to Kafka Streams users.
```
##########
docs/streams/upgrade-guide.html:
##########
@@ -141,6 +141,22 @@ <h3 class="anchor-heading"><a id="streams_notable_changes"
class="anchor-link"><
<h3><a id="streams_api_changes_400"
href="#streams_api_changes_400">Streams API changes in 4.0.0</a></h3>
+ <p>
+ In this release, eos-v1 (Exactly Once Semantics version 1) is no
longer supported. Additionally, all deprecated methods, classes, APIs, and
config parameters
+ up to (including) AK 3.5 release have been removed.
Review Comment:
Good question... It might be worth to highlight a few important ones like
old Processor API, KStream#[flat]Transform[Values], KStream#through,
KStream#branch, Time/Session/SlidingWindows#of(), and
KafkaStreams#setUncaughtExceptionHandler ?)
And it might be good to link to the Jira ticket for details:
https://issues.apache.org/jira/browse/KAFKA-12822
For EOSv1, we should also call out that EOSv2 requires broker version 2.5+.
##########
docs/streams/upgrade-guide.html:
##########
@@ -161,6 +177,65 @@ <h3><a id="streams_api_changes_400"
href="#streams_api_changes_400">Streams API
<code>TransformerSupplier</code>, <code>ValueTransformer</code>, and
<code>ValueTransformerSupplier</code>.
</p>
+ <p>
+ Kafka Streams introduced the <code>RETRY</code> return option the
<code>ProductionExceptionHandler</code> (<a
href="https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=311627309";>KIP-1065</a>).
+ This feature addresses the issue of infinite retry loops caused by
<code>TimeoutException</code> when an output topic might be missing.
+ Now the application is enabled to attempt the action again instead of
either crashing or dropping records.
+ This change aims to enhance the robustness and reliability of Kafka
Streams by providing a more flexible error-handling mechanism.
+ </p>
+
+ <p>
+
+ </p>
+ <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1076%3A++Metrics+for+client+applications+KIP-714+extension";>KIP-1076</a>
+ proposes adding methods to the Admin, Consumer, and Producer
interfaces to allow applications embedding Kafka clients to register and push
application-specific metrics,
+ supplementing the client metrics introduced in KIP-714.
+
+ <p>
+ <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1077%3A+Deprecate+%60ForeachProcessor%60+and+move+to+internal+package";>KIP-1077</a>
+ deprecates the <code>ForeachProcessor</code> class and move it to an
internal package.
+ This change is aimed at improving the organization and clarity of the
Kafka Streams API by ensuring that internal classes are not exposed in public
packages.
+ </p>
+
+ <p>
+ <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1078%3A+Remove+Leaking+Getter+Methods+in+Joined+Helper+Class";>KIP-1078</a>
deprecates the leaking getter methods in the <code>Joined</code> helper class.
+ These methods should be deprecated for future removal as they are
already available via <code>JoinedInternal</code> class.
+ </p>
+
+ <p>
+ To ensures better encapsulation and organization of configuration
documentation within Kafka Streams,
+ <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1085%3A+Fix+leaking+*_DOC+variables+in+StreamsConfig";>KIP-1085</a>
+ deprecate certain public doc description variables that are only used
within the <code>StreamsConfig</code> or <code>TopologyConfig</code> classes.
+ Additionally, the unused variable <code>DUMMY_THREAD_INDEX</code> will
also be deprecated.
+ </p>
+
+ <p>
+ Due to the recent deprecation of the <code>#through</code> method in
Kafka Streams, the <code>intermediateTopicsOption</code> of
<code>StreamsResetter</code> tool in Apache Kafka is
+ not needed any more and therefore is deprecated (<a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1087%3A+Removing+intermediateTopicsOption+from+StreamsResetter";>KIP-1087</a>).
+ </p>
+
+ <p>
+ In this release, explicit status information about the application's
health is provided by new numeric metrics for both client-level and
thread-level states
+ (<a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1091%3A+Improved+Kafka+Streams+operator+metrics";>KIP-1091</a>).
+ These metrics will be available at the <code>INFO</code> recording
level, and a thread-level metric with a String value will be available for
users leveraging Java Management Extensions (<code>JMX</code>).
+ </p>
+
+ <p>
Review Comment:
Not a KS KIP. I would remove this paragraph.
##########
docs/streams/upgrade-guide.html:
##########
@@ -141,6 +141,22 @@ <h3 class="anchor-heading"><a id="streams_notable_changes"
class="anchor-link"><
<h3><a id="streams_api_changes_400"
href="#streams_api_changes_400">Streams API changes in 4.0.0</a></h3>
+ <p>
+ In this release, eos-v1 (Exactly Once Semantics version 1) is no
longer supported. Additionally, all deprecated methods, classes, APIs, and
config parameters
+ up to (including) AK 3.5 release have been removed.
Review Comment:
We keep 3 release of history, so 3.9/3.8/3.7, right?
I guess, we did not deprecate anything in 3.6, so nothing needed to be
removed, but I would still say 3.6 here?
##########
docs/streams/upgrade-guide.html:
##########
@@ -161,6 +177,65 @@ <h3><a id="streams_api_changes_400"
href="#streams_api_changes_400">Streams API
<code>TransformerSupplier</code>, <code>ValueTransformer</code>, and
<code>ValueTransformerSupplier</code>.
</p>
+ <p>
+ Kafka Streams introduced the <code>RETRY</code> return option the
<code>ProductionExceptionHandler</code> (<a
href="https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=311627309";>KIP-1065</a>).
+ This feature addresses the issue of infinite retry loops caused by
<code>TimeoutException</code> when an output topic might be missing.
+ Now the application is enabled to attempt the action again instead of
either crashing or dropping records.
+ This change aims to enhance the robustness and reliability of Kafka
Streams by providing a more flexible error-handling mechanism.
+ </p>
+
+ <p>
+
+ </p>
+ <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1076%3A++Metrics+for+client+applications+KIP-714+extension";>KIP-1076</a>
+ proposes adding methods to the Admin, Consumer, and Producer
interfaces to allow applications embedding Kafka clients to register and push
application-specific metrics,
+ supplementing the client metrics introduced in KIP-714.
+
+ <p>
+ <a
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-1077%3A+Deprecate+%60ForeachProcessor%60+and+move+to+internal+package";>KIP-1077</a>
+ deprecates the <code>ForeachProcessor</code> class and move it to an
internal package.
Review Comment:
No important, and an impl detail that we keep it in an internal package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
