frankvicky commented on code in PR #17373:
URL: https://github.com/apache/kafka/pull/17373#discussion_r1894121803
##########
build.gradle:
##########
@@ -2441,13 +2459,18 @@ project(':tools') {
implementation libs.jacksonDataformatCsv
implementation libs.jacksonJDK8Datatypes
implementation libs.slf4jApi
- implementation libs.slf4jReload4j
+ implementation libs.slf4jLog4j2
+ implementation libs.log4j2Api
+ implementation libs.log4j2Core
+ implementation libs.log4j1Bridge2Api
implementation libs.joptSimple
implementation libs.re2j
implementation libs.jose4j // for SASL/OAUTHBEARER JWT
validation
implementation libs.jacksonJakartarsJsonProvider
+ compileOnly libs.spotbugs
Review Comment:
I added `spotbugs` to address the compiler warnings. While we could suppress
these warnings using `-Xlint:all,-classFile`, I prefer not to relax compiler
checks.
Ideally, we should avoid depending on core-specific methods altogether.
However, that would require thorough pass to our code. I suggest we create a
separate JIRA ticket to track this architectural improvement as a future
enhancement.
For further details:
https://github.com/apache/logging-log4j2/issues/2144#issue-2061148244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
