kirktrue commented on PR #17700: URL: https://github.com/apache/kafka/pull/17700#issuecomment-2557819212
@junrao—I was finally able to test your proposed change against the two group protocols. The following shows the `CLASSIC` and `CONSUMER` group protocols using the existing fetcher logic (AKA "option 1") and your proposed fetcher logic (AKA "option 4"): `CLASSIC` group protocol, existing fetch logic: <img width="700" alt="CLASSIC, mode 1" src="https://github.com/user-attachments/assets/32cb710a-8a5f-406e-9b42-a430a39414c9"; /> `CLASSIC` group protocol, new fetch logic: <img width="700" alt="CLASSIC, mode 4" src="https://github.com/user-attachments/assets/098af5a9-f3cb-4649-8206-5432b723d599"; /> `CONSUMER` group protocol, existing fetch logic: <img width="700" alt="CONSUMER, mode 1" src="https://github.com/user-attachments/assets/b78425a8-c90f-4c3f-8514-42447c391dab"; /> `CONSUMER` group protocol, new fetch logic: <img width="700" alt="CONSUMER, mode 4" src="https://github.com/user-attachments/assets/16c8f8ae-2e65-4f84-9b50-3ebada678bec"; /> In the end, the `CLASSIC` group protocol doesn't seem to benefit from the new approach, at least in this particular workload. The changed logic doesn't seem to “hurt” it, either, though. However, the `CONSUMER` group protocol certainly does benefit from your proposed change. In total, the change, if applied to both protocols, is a net win. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
