chia7712 commented on code in PR #18290:
URL: https://github.com/apache/kafka/pull/18290#discussion_r1894767983
##########
build.gradle:
##########
@@ -1588,7 +1588,6 @@ project(':test-common') {
implementation project(':storage')
implementation project(':server-common')
implementation libs.slf4jApi
Review Comment:
Could you please take a look at @ijuma's comment
(https://github.com/apache/kafka/pull/17373#discussion_r1894553658)
maybe we can create a variable to collect them and then add them to
implementation for each module:
```
log4jRuntimeLibs = [
libs.log4j1Bridge2Api
libs.jacksonDatabindYaml
]
log4jLibs = [
libs.slf4jApi
libs.slf4jLog4j2
libs.log4j2Api
libs.log4j2Core
]
...
implementation log4jLibs
runtimeOnly log4jRuntimeLibs
```
##########
build.gradle:
##########
@@ -1588,7 +1588,6 @@ project(':test-common') {
implementation project(':storage')
implementation project(':server-common')
implementation libs.slf4jApi
- implementation libs.jacksonDatabindYaml
Review Comment:
this is required as `test-common` needs to parse yaml in production code.
##########
docs/upgrade.html:
##########
@@ -227,6 +227,11 @@ <h5><a id="upgrade_400_notable"
href="#upgrade_400_notable">Notable changes in 4
Java 8 support has been removed in Apache Kafka 4.0
See <a
href="https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=181308223";>KIP-750</a>
for more details
</li>
+ <li>
+ Logging framework has been migrated from Log4j to Log4j2.
Review Comment:
Log4j provides a way to convert Log4j 1.x properties at runtime ([Log4j
Migration
Guide](https://logging.apache.org/log4j/2.x/migrate-from-log4j1.html#ConfigurationCompatibility)).
To enable this feature, we can set both `LOG4J_COMPATIBILITY=true` and
specify the configuration file using `LOG4J_CONFIGURATION_FILE=file`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
