ijuma commented on code in PR #18080:
URL: https://github.com/apache/kafka/pull/18080#discussion_r1894812224
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -147,8 +148,9 @@ public class ProducerConfig extends AbstractConfig {
+ "of as analogous to Nagle's
algorithm in TCP. This setting gives the upper bound on the delay for batching:
once "
+ "we get <code>" +
BATCH_SIZE_CONFIG + "</code> worth of records for a partition it will be sent
immediately regardless of this "
+ "setting, however if we have
fewer than this many bytes accumulated for this partition we will 'linger' for
the "
- + "specified time waiting for
more records to show up. This setting defaults to 0 (i.e. no delay). Setting
<code>" + LINGER_MS_CONFIG + "=5</code>, "
- + "for example, would have the
effect of reducing the number of requests sent but would add up to 5ms of
latency to records sent in the absence of load.";
+ + "specified time waiting for
more records to show up. This setting defaults to 5 (i.e. 5ms delay).
Increasing <code>" + LINGER_MS_CONFIG + "=50</code>, "
+ + "for example, would have the
effect of reducing the number of requests sent but would add up to 50ms of
latency to records sent in the absence of load."
Review Comment:
I don't follow, we seem to be saying that increasing from 5ms to 50ms would
add up to 50ms of latency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
