kirktrue commented on code in PR #17669:
URL: https://github.com/apache/kafka/pull/17669#discussion_r1899766473
##########
tests/kafkatest/services/verifiable_consumer.py:
##########
@@ -398,8 +398,9 @@ def start_cmd(self, node):
# The two implementations use slightly different configuration, hence
these arguments are conditional.
#
# See the Java class/method VerifiableConsumer.createFromArgs() for
how the command line arguments are
- # parsed and used as configuration in the runner.
- if node.version >= V_3_7_0 and
self.is_consumer_group_protocol_enabled():
+ # parsed and used as configuration in the runner. Note: even though
support for the two group protocols was
+ # introduced in 3.7.0, support for the --group-protocol option was not
added until later.
+ if node.version > V_3_7_1 and self.group_protocol:
Review Comment:
Sorry for the late reply. System tests have been blocked by an environmental
issue in our build environment. I believe this is now fixed, so I will start a
test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
