TaiJuWu commented on code in PR #18296:
URL: https://github.com/apache/kafka/pull/18296#discussion_r1900565069
##########
clients/src/test/java/org/apache/kafka/clients/admin/DeleteConsumerGroupOffsetsResultTest.java:
##########
@@ -63,7 +63,7 @@ public void testTopLevelErrorConstructor() throws
InterruptedException {
partitionFutures.completeExceptionally(Errors.GROUP_AUTHORIZATION_FAILED.exception());
DeleteConsumerGroupOffsetsResult topLevelErrorResult =
new DeleteConsumerGroupOffsetsResult(partitionFutures, partitions);
- TestUtils.assertFutureError(topLevelErrorResult.all(),
GroupAuthorizationException.class);
+ TestUtils.assertFutureThrows(topLevelErrorResult.all(),
GroupAuthorizationException.class);
Review Comment:
Could we align junit conversation and make it become
assertFutureThrows(Class<T> expectedCauseClassApiException, Future<?> future)?
Just a suggestion not a requirement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
