YunKuiLu commented on code in PR #18199:
URL: https://github.com/apache/kafka/pull/18199#discussion_r1900949690
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##########
@@ -479,7 +479,7 @@ private <T> ConfigInfos validateConverterConfig(
return null;
} catch (InvalidVersionSpecificationException e) {
// this should have been caught by prior validation logic
- log.error("Invalid version range for {} class {}: {}", pluginName,
pluginClass, pluginVersion, e);
+ log.error("Invalid version range for {} class {} with version {}",
pluginName, pluginClass, pluginVersion, e);
Review Comment:
before:
```
[2025-01-02 22:42:08,659] INFO Validating connector
org.apache.kafka.connect.runtime.SampleSourceConnector, version some great
version (org.apache.kafka.connect.runtime.AbstractHerder:830)
[2025-01-02 22:42:09,014] ERROR Invalid version range for header converter
class org.apache.kafka.connect.storage.SimpleHeaderConverter: [1.0
(org.apache.kafka.connect.runtime.AbstractHerder:482)
org.apache.maven.artifact.versioning.InvalidVersionSpecificationException:
Unbounded range: [1.0
at
org.apache.maven.artifact.versioning.VersionRange.createFromVersionSpec(VersionRange.java:126)
~[maven-artifact-3.9.6.jar:3.9.6]
at
org.apache.kafka.connect.runtime.isolation.PluginUtils.connectorVersionRequirement(PluginUtils.java:504)
~[main/:?]
at
org.apache.kafka.connect.runtime.AbstractHerder.validateConverterConfig(AbstractHerder.java:469)
~[main/:?]
at
org.apache.kafka.connect.runtime.AbstractHerder.validateAllConverterConfigs(AbstractHerder.java:534)
~[main/:?]
at
org.apache.kafka.connect.runtime.AbstractHerder.validateConnectorConfig(AbstractHerder.java:863)
~[main/:?]
at
java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
~[?:?]
... ... (more exception trace)
```
after:
```
[2025-01-02 22:38:10,587] INFO Validating connector
org.apache.kafka.connect.runtime.SampleSourceConnector, version some great
version (org.apache.kafka.connect.runtime.AbstractHerder:830)
[2025-01-02 22:38:10,856] ERROR Invalid version range for header converter
class org.apache.kafka.connect.storage.SimpleHeaderConverter with version [1.0
(org.apache.kafka.connect.runtime.AbstractHerder:482)
org.apache.maven.artifact.versioning.InvalidVersionSpecificationException:
Unbounded range: [1.0
at
org.apache.maven.artifact.versioning.VersionRange.createFromVersionSpec(VersionRange.java:126)
~[maven-artifact-3.9.6.jar:3.9.6]
at
org.apache.kafka.connect.runtime.isolation.PluginUtils.connectorVersionRequirement(PluginUtils.java:504)
~[main/:?]
at
org.apache.kafka.connect.runtime.AbstractHerder.validateConverterConfig(AbstractHerder.java:469)
~[main/:?]
at
org.apache.kafka.connect.runtime.AbstractHerder.validateAllConverterConfigs(AbstractHerder.java:534)
~[main/:?]
at
org.apache.kafka.connect.runtime.AbstractHerder.validateConnectorConfig(AbstractHerder.java:863)
~[main/:?]
at
java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:732)
~[?:?]
... ... (more exception trace)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
