[ 
https://issues.apache.org/jira/browse/KAFKA-18402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17909963#comment-17909963
 ] 

Said BOUDJELDA commented on KAFKA-18402:
----------------------------------------

Regarding the licensing and the contribution guides it's more wise to provide 
own optimisation for compareTo method on Uuid class, rather then getting 
inspired by the one of OpenJDK 


> Use openJDK's implementation of comparison for org.apache.kafka.common.Uuid
> ---------------------------------------------------------------------------
>
>                 Key: KAFKA-18402
>                 URL: https://issues.apache.org/jira/browse/KAFKA-18402
>             Project: Kafka
>          Issue Type: Improvement
>          Components: clients
>            Reporter: Said BOUDJELDA
>            Assignee: Said BOUDJELDA
>            Priority: Minor
>              Labels: common
>             Fix For: 4.1.0
>
>
> The the reference implementation for org.apache.kafka.common.Uuid compareTo 
> public method as  of java.util.UUID  
> {code:java}
>     @Override
>     public int compareTo(UUID val) {
>         // The ordering is intentionally set up so that the UUIDs
>         // can simply be numerically compared as two numbers
>         int mostSigBits = Long.compare(this.mostSigBits, val.mostSigBits);
>         return mostSigBits != 0 ? mostSigBits : 
> Long.compare(this.leastSigBits, val.leastSigBits);
>     }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to