chia7712 commented on code in PR #18384: URL: https://github.com/apache/kafka/pull/18384#discussion_r1904920541
########## core/src/main/scala/kafka/server/KafkaConfig.scala: ########## @@ -526,8 +437,6 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) } /** ********* Controlled shutdown configuration ***********/ - val controlledShutdownMaxRetries = getInt(ServerConfigs.CONTROLLED_SHUTDOWN_MAX_RETRIES_CONFIG) - val controlledShutdownRetryBackoffMs = getLong(ServerConfigs.CONTROLLED_SHUTDOWN_RETRY_BACKOFF_MS_CONFIG) Review Comment: > We should also add a note to the zk to kraft migration guide regarding this. Said the same in the JIRA ticket. Yes, I have added the note to KAFKA-18364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
