cadonna commented on code in PR #18275:
URL: https://github.com/apache/kafka/pull/18275#discussion_r1905151534
##########
docs/streams/upgrade-guide.html:
##########
@@ -173,6 +173,16 @@ <h3><a id="streams_api_changes_400"
href="#streams_api_changes_400">Streams API
See <a href="https://cwiki.apache.org/confluence/x/TZCMEw";>KIP-1112</a>
for more details.
</p>
+ <p>
+ Upgraded RocksDB dependency to version 9.7.3 (from 7.9.2). This
upgrade incorporates various improvements and optimizations within RocksDB.
However, it also introduces some API changes.
+ The <code>org.rocksdb.AccessHint</code> class, along with its
associated methods, has been removed.
+ The <code>org.rocksdb.BlockBasedTableConfig</code> class, along with
its associated methods, has been removed.
+ The <code>NO_FILE_CLOSES</code> field has been removed from the
<code>org.rocksdb.TickerTypeenum</code> as a result the
<code>number-open-files</code> metrics does not work as expeced.
Review Comment:
```suggestion
The <code>NO_FILE_CLOSES</code> field has been removed from the
<code>org.rocksdb.TickerTypeenum</code> as a result the
<code>number-open-files</code> metrics does not work as expected. Metric
<code>number-open-files</code> returns constant -1 from now on until it will
officially be removed.
```
##########
docs/streams/upgrade-guide.html:
##########
@@ -173,6 +173,16 @@ <h3><a id="streams_api_changes_400"
href="#streams_api_changes_400">Streams API
See <a href="https://cwiki.apache.org/confluence/x/TZCMEw";>KIP-1112</a>
for more details.
</p>
+ <p>
+ Upgraded RocksDB dependency to version 9.7.3 (from 7.9.2). This
upgrade incorporates various improvements and optimizations within RocksDB.
However, it also introduces some API changes.
+ The <code>org.rocksdb.AccessHint</code> class, along with its
associated methods, has been removed.
+ The <code>org.rocksdb.BlockBasedTableConfig</code> class, along with
its associated methods, has been removed.
Review Comment:
`BlockBasedTableConfig` has not been removed. Just a couple of methods on
this class have been removed.
##########
docs/streams/upgrade-guide.html:
##########
@@ -173,6 +173,16 @@ <h3><a id="streams_api_changes_400"
href="#streams_api_changes_400">Streams API
See <a href="https://cwiki.apache.org/confluence/x/TZCMEw";>KIP-1112</a>
for more details.
</p>
+ <p>
+ Upgraded RocksDB dependency to version 9.7.3 (from 7.9.2). This
upgrade incorporates various improvements and optimizations within RocksDB.
However, it also introduces some API changes.
+ The <code>org.rocksdb.AccessHint</code> class, along with its
associated methods, has been removed.
+ The <code>org.rocksdb.BlockBasedTableConfig</code> class, along with
its associated methods, has been removed.
+ The <code>NO_FILE_CLOSES</code> field has been removed from the
<code>org.rocksdb.TickerTypeenum</code> as a result the
<code>number-open-files</code> metrics does not work as expeced.
+ The <code>org.rocksdb.Options.setLogger()</code> method now accepts a
<code>LoggerInterface</code> as a parameter instead of the previous
<code>Logger</code>.
+ Some data types used in RocksDB's Java API have been modified. These
changes, along with the removed class, field, and new methods, are primarily
relevant to users implementing custom RocksDB configurations.
+ These changes are expected to be largely transparent to most Kafka
Streams users. However, those employing advanced RocksDB customizations within
their Streams applications, particularly through the
<code>rocksdb.config.setter</code>, are advised to consult the detailed RocksDB
9.7.3 changelog to ensure a smooth transition and adapt their configurations as
needed. Specifically, users leveraging the removed
<code>AccessHintclass</code>, the <code>NO_FILE_CLOSES</code> field from
<code>TickerType</code>, or relying on the previous signature of
<code>setLogger()</code> will need to update their implementations.
Review Comment:
```suggestion
These changes are expected to be largely transparent to most Kafka
Streams users. However, those employing advanced RocksDB customizations within
their Streams applications, particularly through the
<code>rocksdb.config.setter</code>, are advised to consult the detailed RocksDB
9.7.3 changelog to ensure a smooth transition and adapt their configurations as
needed. Specifically, users leveraging the removed <code>AccessHint</code>
class, the removed methods from the <code>BlockBasedTableConfig</code> class,
the <code>NO_FILE_CLOSES</code> field from <code>TickerType</code>, or relying
on the previous signature of <code>setLogger()</code> will need to update their
implementations.
```
##########
docs/ops.html:
##########
@@ -3475,7 +3475,7 @@ <h5 class="anchor-heading"><a
id="kafka_streams_rocksdb_monitoring" class="ancho
</tr>
<tr>
<td>number-open-files</td>
- <td>The number of current open files.</td>
+ <td>This metric will return constant -1 and no longer reliable because
it depended on NO_FILE_CLOSES, which was removed in RocksDB 9.7.3</td>
Review Comment:
```suggestion
<td>This metric will return constant -1 because the RocksDB's counter
NO_FILE_CLOSES has been removed in RocksDB 9.7.3</td>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
