Re: [PR] KAFKA-10790: Add deadlock detection to producer#flush [kafka]

Tue, 07 Jan 2025 05:44:43 -0800 


frankvicky commented on code in PR #17946:
URL: https://github.com/apache/kafka/pull/17946#discussion_r1905476456


##########
docs/upgrade.html:
##########
@@ -202,6 +202,8 @@ <h5><a id="upgrade_400_notable" 
href="#upgrade_400_notable">Notable changes in 4
                         </li>
                         <li>The deprecated 
<code>sendOffsetsToTransaction(Map&lt;TopicPartition, OffsetAndMetadata&gt;, 
String)</code> method has been removed from the Producer API.
                         </li>
+                        <li>The <code>flush</code> method now detects 
potential deadlocks and prohibits its use inside a callback. This change 
prevents unintended blocking behavior, which was a known risk in earlier 
versions.

Review Comment:
   I have applied the suggestion. Here is the preview:
   ![Screenshot from 2025-01-07 
21-43-32](https://github.com/user-attachments/assets/015a16b1-8268-4965-8aab-e6adb0c842ce)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to