chia7712 commented on code in PR #18417:
URL: https://github.com/apache/kafka/pull/18417#discussion_r1908117518
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -3034,99 +3032,7 @@ class KafkaApisTest extends Logging {
val markersResponse = capturedResponse.getValue
assertEquals(2, markersResponse.errorsByProducerId.size())
}
-
- @Test
Review Comment:
Could you please add unit test to ensure those removed RPC can see correct
error?
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -197,9 +196,6 @@ class KafkaApis(val requestChannel: RequestChannel,
case ApiKeys.FETCH => handleFetchRequest(request)
case ApiKeys.LIST_OFFSETS => handleListOffsetRequest(request)
case ApiKeys.METADATA => handleTopicMetadataRequest(request)
- case ApiKeys.LEADER_AND_ISR => handleLeaderAndIsrRequest(request)
- case ApiKeys.STOP_REPLICA => handleStopReplicaRequest(request)
- case ApiKeys.UPDATE_METADATA => handleUpdateMetadataRequest(request,
requestLocal)
Review Comment:
ditto
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -197,9 +196,6 @@ class KafkaApis(val requestChannel: RequestChannel,
case ApiKeys.FETCH => handleFetchRequest(request)
case ApiKeys.LIST_OFFSETS => handleListOffsetRequest(request)
case ApiKeys.METADATA => handleTopicMetadataRequest(request)
- case ApiKeys.LEADER_AND_ISR => handleLeaderAndIsrRequest(request)
- case ApiKeys.STOP_REPLICA => handleStopReplicaRequest(request)
Review Comment:
ditto
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -197,9 +196,6 @@ class KafkaApis(val requestChannel: RequestChannel,
case ApiKeys.FETCH => handleFetchRequest(request)
case ApiKeys.LIST_OFFSETS => handleListOffsetRequest(request)
case ApiKeys.METADATA => handleTopicMetadataRequest(request)
- case ApiKeys.LEADER_AND_ISR => handleLeaderAndIsrRequest(request)
Review Comment:
Could you please use `KafkaApis.shouldNeverReceive` to keep the same error
message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
