dajac commented on code in PR #18320:
URL: https://github.com/apache/kafka/pull/18320#discussion_r1908927984
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -542,15 +542,7 @@ class KafkaConfig private(doLog: Boolean, val props:
util.Map[_, _])
if (!protocols.contains(GroupType.CLASSIC)) {
throw new ConfigException(s"Disabling the '${GroupType.CLASSIC}'
protocol is not supported.")
}
- if (protocols.contains(GroupType.CONSUMER)) {
- if (processRoles.isEmpty || !isNewGroupCoordinatorEnabled) {
- warn(s"The new '${GroupType.CONSUMER}' rebalance protocol is only
supported in KRaft cluster with the new group coordinator.")
- }
- }
if (protocols.contains(GroupType.SHARE)) {
- if (processRoles.isEmpty || !isNewGroupCoordinatorEnabled) {
Review Comment:
ditto.
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -542,15 +542,7 @@ class KafkaConfig private(doLog: Boolean, val props:
util.Map[_, _])
if (!protocols.contains(GroupType.CLASSIC)) {
throw new ConfigException(s"Disabling the '${GroupType.CLASSIC}'
protocol is not supported.")
}
- if (protocols.contains(GroupType.CONSUMER)) {
- if (processRoles.isEmpty || !isNewGroupCoordinatorEnabled) {
- warn(s"The new '${GroupType.CONSUMER}' rebalance protocol is only
supported in KRaft cluster with the new group coordinator.")
Review Comment:
We could remove `in KRaft cluster`
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -542,15 +542,7 @@ class KafkaConfig private(doLog: Boolean, val props:
util.Map[_, _])
if (!protocols.contains(GroupType.CLASSIC)) {
throw new ConfigException(s"Disabling the '${GroupType.CLASSIC}'
protocol is not supported.")
}
- if (protocols.contains(GroupType.CONSUMER)) {
- if (processRoles.isEmpty || !isNewGroupCoordinatorEnabled) {
Review Comment:
I think that we need to keep the second part of the condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
