apoorvmittal10 commented on code in PR #18408:
URL: https://github.com/apache/kafka/pull/18408#discussion_r1909019268
##########
storage/src/main/java/org/apache/kafka/storage/log/metrics/BrokerTopicMetrics.java:
##########
@@ -77,7 +76,6 @@ private BrokerTopicMetrics(Optional<String> name, boolean
remoteStorageEnabled)
metricTypeMap.put(FAILED_FETCH_REQUESTS_PER_SEC, new
MeterWrapper(FAILED_FETCH_REQUESTS_PER_SEC, "requests"));
metricTypeMap.put(TOTAL_PRODUCE_REQUESTS_PER_SEC, new
MeterWrapper(TOTAL_PRODUCE_REQUESTS_PER_SEC, "requests"));
metricTypeMap.put(TOTAL_FETCH_REQUESTS_PER_SEC, new
MeterWrapper(TOTAL_FETCH_REQUESTS_PER_SEC, "requests"));
- metricTypeMap.put(FETCH_MESSAGE_CONVERSIONS_PER_SEC, new
MeterWrapper(FETCH_MESSAGE_CONVERSIONS_PER_SEC, "requests"));
Review Comment:
@chia7712 As I understand with the discussion that we would like to keep the
metric till 5.0 as it's greedily instatitated. Hence adding a deprecated tag
might not be helpful as the BrokerTopicMetrics which doesn't have a tag are
only greedily instatiated. To change the behaviour and add a deprecated tag
will have more work than the value I feel.
What about if we update the kafka-site
(https://github.com/apache/kafka/blob/64b8b4a6321d4afceba960470fc585cdaa353d34/docs/ops.html#L1458)
documentation to have the deprecation details and remove the metric in 5.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
